dani/lyne-dev
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

Cleanup agentic coding artifacts #3

New issue
Open
opened 2026-08-10 11:54:31 -04:00 by dani · 1 comment
dani commented 2026-08-10 11:54:31 -04:00
Owner
Copy link

I used agents to prototype #2, so I need to analyze, review for, and clean up any "smelly" artifacts that they leave behind after it is merged.

  • Perform manual audit of redesign and note everything wrong in this issue below.
  • Solve each point below after audit has been completed.
I used agents to prototype #2, so I need to analyze, review for, and clean up any "smelly" artifacts that they leave behind after it is merged. - [ ] Perform manual audit of redesign and note everything wrong in this issue below. - [ ] Solve each point below after audit has been completed.
dani self-assigned this 2026-08-10 11:54:31 -04:00
dani commented 2026-08-30 20:29:30 -04:00
Author
Owner
Copy link

Some thoughts:

  • Improper abstractions
    • resolve_theme utility function and repeated query extractor used in place of FromRequestParts implementor.
    • Overly verbose router specification. Improperly hierarchies in Router construction
  • Code organization smell:
    • experience/mod.rs contains only one submodule common.rs
    • Templating is overly granular
  • Use of JS for simple expansion. Needing multiple GETs to fully expand summaries is unnecessary at best

There are definitely other areas to improve e.g. programmatic testing, more features, etc. But these points above seem like the most in-scope.

Some thoughts: - [ ] Improper abstractions - [ ] `resolve_theme` utility function and repeated query extractor used in place of `FromRequestParts` implementor. - [ ] Overly verbose router specification. Improperly hierarchies in `Router` construction - [ ] Code organization smell: - [ ] `experience/mod.rs` contains only one submodule `common.rs` - [ ] Templating is overly granular - [ ] Use of JS for simple expansion. Needing multiple GETs to fully expand summaries is unnecessary at best There are definitely other areas to improve e.g. programmatic testing, more features, etc. But these points above seem like the most in-scope.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dani
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
dani/lyne-dev#3
No description provided.